GitCorner

Code

ossartcraftvectorcraft🌐
2bc41aeb8602
//! Neutral wording in menus and panels: what users read names VectorCraft's own features.

use egui::epaint::Shape;
use serde_json::{Value, json};
use vectorcraft_engine::Session;

use crate::VectorcraftApp;
use crate::menus::{self, Item};

fn app() -> VectorcraftApp {
    let mut app = VectorcraftApp::new(Session::new(), Default::default());
    app.run("file.new", json!({"width": 100, "height": 100})).unwrap();
    app
}

/// Every string painted by `f` in a headless frame (app fonts installed), one per line. The second
/// of two frames: windows size themselves invisibly in their first.
pub(crate) fn painted_text(app: &mut VectorcraftApp, mut f: impl FnMut(&mut VectorcraftApp, &mut egui::Ui)) -> String {
    let ctx = egui::Context::default();
    crate::theme::install_fonts(&ctx);
    ctx.run_ui(egui::RawInput::default(), |ui| f(app, ui)).textures_delta.clear();
    let mut out = ctx.run_ui(egui::RawInput::default(), |ui| f(app, ui));
    out.textures_delta.clear();
    shapes_text(&out)
}

/// Every string a frame painted, one per line.
pub(crate) fn shapes_text(out: &egui::FullOutput) -> String {
    fn collect(s: &Shape, out: &mut String) {
        match s {
            Shape::Text(t) => {
                out.push_str(t.galley.text());
                out.push('\n');
            }
            Shape::Vec(v) => v.iter().for_each(|s| collect(s, out)),
            _ => {}
        }
    }
    let mut text = String::new();
    for c in &out.shapes {
        collect(&c.shape, &mut text);
    }
    text
}

#[test]
fn effect_menu_has_a_vector_effects_section() {
    let tree = menus::menu_tree();
    let (_, effect) = tree.iter().find(|(t, _)| *t == "Effect").expect("Effect menu");
    assert!(effect.iter().any(|i| matches!(i, Item::Header("Vector Effects"))));
}

/// Effect › Path: Offset Path… opens its dialog; Outline Object and Outline Stroke (no options)
/// apply.
#[test]
fn effect_menu_lists_outline_object_between_offset_path_and_outline_stroke() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let items: Vec<(&str, Option<&str>, &Value)> =
        entries.iter().filter(|e| e.path == ["Effect", "Path"]).map(|e| (e.label.as_str(), e.command.as_deref(), &e.params)).collect();
    assert_eq!(
        items,
        [
            ("Offset Path…", Some("effect.dialog"), &json!({"effect": "path.offsetPath"})),
            ("Outline Object", Some("effect.apply"), &json!({"effect": "path.outlineObject"})),
            ("Outline Stroke", Some("effect.apply"), &json!({"effect": "path.outlineStroke"})),
        ]
    );
}

/// Effect › Rasterize…, an item of its own between Pathfinder and Stylize, opens its options.
#[test]
fn effect_menu_lists_rasterize_between_pathfinder_and_stylize() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let at = |path: &[&str], label: Option<&str>| entries.iter().position(|e| e.path == path && label.is_none_or(|l| e.label == l)).unwrap();
    let rasterize = at(&["Effect"], Some("Rasterize…"));
    assert!(at(&["Effect", "Pathfinder"], None) < rasterize && rasterize < at(&["Effect", "Stylize"], None));
    let e = &entries[rasterize];
    assert_eq!((e.command.as_deref(), e.params["effect"].as_str()), (Some("effect.dialog"), Some("rasterize")));
}

#[test]
fn effect_menu_lists_the_artistic_filters_before_blur() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let artistic: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Artistic"]).collect();
    let labels: Vec<&str> = artistic.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(
        labels,
        [
            "Colored Pencil…",
            "Cutout…",
            "Dry Brush…",
            "Film Grain…",
            "Fresco…",
            "Neon Glow…",
            "Paint Daubs…",
            "Palette Knife…",
            "Plastic Wrap…",
            "Poster Edges…",
            "Rough Pastels…",
            "Smudge Stick…",
            "Sponge…",
            "Underpainting…",
            "Watercolor…"
        ]
    );
    assert!(artistic.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    assert_eq!(artistic[2].params, json!({"effect": "artistic.dryBrush"}));
    assert_eq!(artistic[5].params, json!({"effect": "artistic.neonGlow"}));
    let at = |name: &str| entries.iter().position(|e| e.path == ["Effect", name]).unwrap();
    assert!(at("Artistic") < at("Blur"));
}

/// Paint Daubs' Brush Type menu matches Illustrator's list and uses the effect choice labels.
#[test]
fn paint_daubs_brush_type_menu_matches_illustrator() {
    use crate::dialogs::PAINT_DAUB_BRUSH_TYPE_LABELS;
    use serde_json::Map;
    use vectorcraft_effects::pixel::PAINT_DAUB_BRUSH_TYPES;
    let catalog: Vec<&str> = PAINT_DAUB_BRUSH_TYPES.iter().map(|(label, _)| *label).collect();
    assert_eq!(PAINT_DAUB_BRUSH_TYPE_LABELS.as_slice(), catalog.as_slice());
    let params = Map::new();
    let shown = crate::dialogs::shown_choices("artistic.paintDaubs", "brushType", &params, false).unwrap();
    assert_eq!(shown.len(), PAINT_DAUB_BRUSH_TYPES.len());
    for ((label, value), (english, id)) in shown.iter().zip(PAINT_DAUB_BRUSH_TYPES.iter()) {
        assert_eq!((label.as_str(), value.as_str()), (*english, *id));
    }
}

#[test]
fn effect_menu_lists_the_pixelate_filters_between_blur_and_sharpen() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let pixelate: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Pixelate"]).collect();
    let labels: Vec<&str> = pixelate.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(labels, ["Color Halftone…", "Crystallize…", "Mezzotint…", "Pointillize…"]);
    assert!(pixelate.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    let raster: Vec<&str> =
        entries.iter().filter_map(|e| e.path.get(1).filter(|_| e.path.len() == 2 && e.path[0] == "Effect")).map(String::as_str).collect();
    let at = |name: &str| raster.iter().position(|s| *s == name).unwrap();
    assert!(at("Blur") < at("Pixelate") && at("Pixelate") < at("Sharpen"));
}

/// Effect › Video, after Sharpen: De-Interlace opens its dialog, NTSC Colors (no options) applies.
#[test]
fn effect_menu_lists_the_video_filters_last() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let video: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Video"]).collect();
    let items: Vec<(&str, Option<&str>)> = video.iter().map(|e| (e.label.as_str(), e.command.as_deref())).collect();
    assert_eq!(items, [("De-Interlace…", Some("effect.dialog")), ("NTSC Colors", Some("effect.apply"))]);
    let raster: Vec<&str> =
        entries.iter().filter_map(|e| e.path.get(1).filter(|_| e.path.len() == 2 && e.path[0] == "Effect")).map(String::as_str).collect();
    let at = |name: &str| raster.iter().position(|s| *s == name).unwrap();
    assert!(at("Sharpen") < at("Video"));
}

/// Effect › Distort, between Blur and Pixelate: each filter opens its dialog.
#[test]
fn effect_menu_lists_the_distort_filters_between_blur_and_pixelate() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let distort: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Distort"]).collect();
    let labels: Vec<&str> = distort.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(labels, ["Diffuse Glow…", "Glass…", "Ocean Ripple…"]);
    assert!(distort.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    let raster: Vec<&str> =
        entries.iter().filter_map(|e| e.path.get(1).filter(|_| e.path.len() == 2 && e.path[0] == "Effect")).map(String::as_str).collect();
    let at = |name: &str| raster.iter().position(|s| *s == name).unwrap();
    assert!(at("Blur") < at("Distort") && at("Distort") < at("Pixelate"));
    // The vector Distort & Transform stays its own submenu.
    assert!(raster.contains(&"Distort & Transform"));
}

/// Effect › Brush Strokes, between Blur and Distort: each filter opens its dialog.
#[test]
fn effect_menu_lists_the_brush_strokes_filters_between_blur_and_distort() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let strokes: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Brush Strokes"]).collect();
    let labels: Vec<&str> = strokes.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(
        labels,
        ["Accented Edges…", "Angled Strokes…", "Crosshatch…", "Dark Strokes…", "Ink Outlines…", "Spatter…", "Sprayed Strokes…", "Sumi-e…"]
    );
    assert!(strokes.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    let raster: Vec<&str> =
        entries.iter().filter_map(|e| e.path.get(1).filter(|_| e.path.len() == 2 && e.path[0] == "Effect")).map(String::as_str).collect();
    let at = |name: &str| raster.iter().position(|s| *s == name).unwrap();
    assert!(at("Blur") < at("Brush Strokes") && at("Brush Strokes") < at("Distort"));
}

/// Effect › Texture, between Sharpen and Video: each filter opens its dialog.
#[test]
fn effect_menu_lists_the_texture_filters_between_sharpen_and_video() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let texture: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Texture"]).collect();
    let labels: Vec<&str> = texture.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(labels, ["Craquelure…", "Grain…", "Mosaic Tiles…", "Patchwork…", "Stained Glass…", "Texturizer…"]);
    assert!(texture.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    let raster: Vec<&str> =
        entries.iter().filter_map(|e| e.path.get(1).filter(|_| e.path.len() == 2 && e.path[0] == "Effect")).map(String::as_str).collect();
    let at = |name: &str| raster.iter().position(|s| *s == name).unwrap();
    assert!(at("Sharpen") < at("Texture") && at("Texture") < at("Video"));
}

/// Effect › Sketch, between Sharpen and the raster Stylize: the raster sketch filters open their dialogs.
#[test]
fn effect_menu_lists_the_sketch_filters_between_sharpen_and_stylize() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let sketch: Vec<_> = entries.iter().filter(|e| e.path == ["Effect", "Sketch"]).collect();
    let labels: Vec<&str> = sketch.iter().map(|e| e.label.as_str()).collect();
    assert_eq!(
        labels,
        [
            "Bas Relief…",
            "Chalk & Charcoal…",
            "Charcoal…",
            "Chrome…",
            "Conté Crayon…",
            "Graphic Pen…",
            "Halftone Pattern…",
            "Note Paper…",
            "Photocopy…",
            "Plaster…",
            "Reticulation…",
            "Stamp…",
            "Torn Edges…",
            "Water Paper…"
        ]
    );
    assert!(sketch.iter().all(|e| e.command.as_deref() == Some("effect.dialog")));
    assert_eq!(sketch[0].params, json!({"effect": "sketch.basRelief"}));
    assert_eq!(sketch[1].params, json!({"effect": "sketch.chalkCharcoal"}));
    assert_eq!(sketch[2].params, json!({"effect": "sketch.charcoal"}));
    assert_eq!(sketch[3].params, json!({"effect": "sketch.chrome"}));
    assert_eq!(sketch[4].params, json!({"effect": "sketch.conteCrayon"}));
    assert_eq!(sketch[5].params, json!({"effect": "sketch.graphicPen"}));
    assert_eq!(sketch[6].params, json!({"effect": "sketch.halftonePattern"}));
    assert_eq!(sketch[7].params, json!({"effect": "sketch.notePaper"}));
    assert_eq!(sketch[8].params, json!({"effect": "sketch.photocopy"}));
    assert_eq!(sketch[9].params, json!({"effect": "sketch.plaster"}));
    assert_eq!(sketch[10].params, json!({"effect": "sketch.reticulation"}));
    assert_eq!(sketch[11].params, json!({"effect": "sketch.stamp"}));
    assert_eq!(sketch[12].params, json!({"effect": "sketch.tornEdges"}));
    assert_eq!(sketch[13].params, json!({"effect": "sketch.waterPaper"}));
    let at = |label: &str| entries.iter().position(|e| e.path[0] == "Effect" && e.label == label).unwrap();
    assert!(at("Unsharp Mask…") < at("Bas Relief…") && at("Bas Relief…") < at("Chalk & Charcoal…"));
    assert!(at("Chalk & Charcoal…") < at("Chrome…"));
    assert!(at("Chrome…") < at("Conté Crayon…") && at("Conté Crayon…") < at("Graphic Pen…") && at("Graphic Pen…") < at("Halftone Pattern…"));
    assert!(at("Halftone Pattern…") < at("Note Paper…") && at("Note Paper…") < at("Plaster…"));
    assert!(at("Plaster…") < at("Reticulation…"));
    assert!(at("Reticulation…") < at("Torn Edges…") && at("Torn Edges…") < at("Water Paper…") && at("Water Paper…") < at("Glowing Edges…"));
}

/// Effect › Stylize under Raster Effects, between Sharpen and Texture: Glowing Edges opens its
/// dialog.
#[test]
fn effect_menu_lists_glowing_edges_in_the_raster_stylize_between_sharpen_and_texture() {
    let app = app();
    let entries = menus::menu_entries(&app);
    let at = |label: &str| entries.iter().position(|e| e.path[0] == "Effect" && e.label == label).unwrap();
    let glowing = &entries[at("Glowing Edges…")];
    assert_eq!(glowing.path, ["Effect", "Stylize"]);
    assert_eq!(glowing.command.as_deref(), Some("effect.dialog"));
    assert_eq!(glowing.params, json!({"effect": "stylize.glowingEdges"}));
    assert!(at("Unsharp Mask…") < at("Glowing Edges…") && at("Glowing Edges…") < at("Craquelure…"));
}

/// The vector effects' Stylize keeps its six effects and leaves Glowing Edges out.
#[test]
fn effect_menu_keeps_glowing_edges_out_of_the_vector_stylize() {
    let tree = menus::menu_tree();
    let (_, effect) = tree.iter().find(|(t, _)| *t == "Effect").expect("Effect menu");
    let raster = effect.iter().position(|i| matches!(i, Item::Header("Raster Effects"))).expect("Raster Effects");
    let stylize: Vec<(usize, Vec<&str>)> = effect
        .iter()
        .enumerate()
        .filter_map(|(i, it)| match it {
            Item::Sub("Stylize", items) => Some((i, items.iter().filter_map(|c| if let Item::Cmd(l, ..) = c { Some(*l) } else { None }).collect())),
            _ => None,
        })
        .collect();
    assert_eq!(stylize.len(), 2);
    assert!(stylize[0].0 < raster && raster < stylize[1].0);
    assert_eq!(stylize[0].1, ["Round Corners…", "Scribble…", "Drop Shadow…", "Inner Glow…", "Outer Glow…", "Feather…"]);
    assert_eq!(stylize[1].1, ["Glowing Edges…"]);
}

#[test]
fn window_library_submenus_have_no_placeholders() {
    let app = app();
    let entries = menus::menu_entries(&app);
    for lib in ["Brush Libraries", "Graphic Style Libraries", "Swatch Libraries", "Symbol Libraries"] {
        let items: Vec<_> = entries
            .iter()
            .filter(|e| e.path.first().map(String::as_str) == Some("Window") && e.path.get(1).map(String::as_str) == Some(lib))
            .collect();
        assert!(!items.is_empty(), "{lib}");
        assert!(items.iter().all(|e| e.command.is_some()), "{lib}: {:?}", items.iter().map(|e| &e.label).collect::<Vec<_>>());
    }
}

#[test]
fn stroke_profiles_have_descriptive_names() {
    let labels: Vec<&str> = vectorcraft_doc::WidthProfile::PRESETS.iter().map(|p| p.label).collect();
    assert_eq!(labels, ["Uniform", "Lens", "Taper Start", "Taper End", "Pinch", "Teardrop", "Wave"]);
}

#[test]
fn swatches_menu_offers_save_swatch_library() {
    let mut app = app();
    let text = painted_text(&mut app, crate::panels::swatches::menu);
    assert!(text.contains("Save Swatch Library…"), "{text}");
    assert!(!text.contains("ASE"), "{text}");
}

#[test]
fn edit_menu_lists_pdf_presets() {
    let app = app();
    // Implemented (M4.44): enabled, and it opens Edit → PDF Presets.
    assert!(
        menus::menu_entries(&app)
            .iter()
            .any(|e| e.path == ["Edit"] && e.label == "PDF Presets…" && e.enabled && e.command.as_deref() == Some("ui.pdfPresetsDialog"))
    );
}

#[test]
fn clipboard_preferences_name_the_legacy_format_neutrally() {
    let label = |key: &str| vectorcraft_engine::cmd::prefscmds::PREF_SPECS.iter().find(|p| p.key == key).unwrap().label;
    assert_eq!(label("copyAicb"), "Legacy vector clipboard (no transparency)");
    assert_eq!(label("aicbMode"), "Legacy vector clipboard");
}

#[test]
fn shortcut_set_old_name_is_accepted() {
    use crate::shortcut_editor::{PRESETS, import_json};
    let (old, _) = crate::shortcut_editor::LEGACY_PRESETS[0];
    assert_eq!(PRESETS, ["VectorCraft Defaults", "Classic Defaults"]);
    // UI preferences saved by an earlier version load (and save again) under the current name.
    let ui: crate::state::UiState = serde_json::from_value(json!({ "shortcut_set": old })).unwrap();
    assert_eq!(ui.shortcut_set, "Classic Defaults");
    let saved = serde_json::to_value(&ui).unwrap();
    assert_eq!(saved["shortcut_set"], "Classic Defaults");
    let back: crate::state::UiState = serde_json::from_value(saved).unwrap();
    assert_eq!(back.shortcut_set, "Classic Defaults");
    let default: crate::state::UiState = serde_json::from_value(json!({})).unwrap();
    assert_eq!(default.shortcut_set, PRESETS[0]);
    // The command and imported sets take the old name too.
    let mut app = app();
    app.run("shortcuts.preset", json!({ "name": old })).unwrap();
    assert_eq!(app.ui.shortcut_set, "Classic Defaults");
    app.run("shortcuts.preset", json!({ "name": "VectorCraft Defaults" })).unwrap();
    assert_eq!(app.ui.shortcut_set, "VectorCraft Defaults");
    assert!(app.run("shortcuts.preset", json!({ "name": "Nope" })).is_err());
    let (set, _) = import_json(&json!({ "set": old, "overrides": {} })).unwrap();
    assert_eq!(set, "Classic Defaults");
}