GitCorner

Code

ossartcraftvectorcraft🌐
2bc41aeb8602
//! The stores of PDF presets and ICC profiles (#2168, #2174): what one session saves, the next one
//! finds; damaged or oversized files are skipped, never fatal.

use serde_json::{Value, json};
use vectorcraft_color::cms;

use crate::Session;
use crate::store::{MAX_PRESET_FILE, file_stem, holds};

fn fresh_dir(tag: &str) -> vectorcraft_testkit::TempDir {
    vectorcraft_testkit::TempDir::new(&format!("store-{tag}"))
}

fn saved_names(s: &mut Session) -> Vec<String> {
    let v = s.execute("pdf.preset.list", &json!({})).unwrap();
    v["presets"].as_array().unwrap().iter().filter(|p| p["builtIn"] == false).map(|p| p["name"].as_str().unwrap().to_string()).collect()
}

#[test]
fn saved_presets_come_back_in_the_next_session_and_renames_and_deletes_follow() {
    let root = fresh_dir("presets");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Press", "description": "for the printer", "preset": "Press Quality"})).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web"})).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web", "newName": "Screen"})).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Old"})).unwrap();
    a.execute("pdf.preset.delete", &json!({"name": "Old"})).unwrap();

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir.clone());
    assert_eq!(saved_names(&mut b), ["Press", "Screen"]);
    let press = b.prefs.pdf_presets.iter().find(|p| p.name == "Press").unwrap();
    assert_eq!(press.description, "for the printer");
    assert_eq!(press.settings, b.pdf_presets().into_iter().find(|p| p.name == "Press Quality").unwrap().settings);
    // The file of a name that is gone is gone.
    assert_eq!(std::fs::read_dir(&dir).unwrap().count(), 2);
    assert!(!dir.join(format!("{}.vcpdfpresets", file_stem("Old"))).exists());
}

#[test]
fn a_rename_that_cannot_be_written_keeps_the_preset_under_its_old_name() {
    let root = fresh_dir("rename-fails");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Web", "description": "for screens"})).unwrap();
    // The test puts a folder where the new name's file goes, so the write fails as it would on a full disk.
    std::fs::create_dir(dir.join(format!("{}.vcpdfpresets", file_stem("Screen")))).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web", "newName": "Screen"})).unwrap();

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir.clone());
    assert_eq!(saved_names(&mut b), ["Web"]);
    assert_eq!(b.prefs.pdf_presets[0].description, "for screens");
    assert!(dir.join(format!("{}.vcpdfpresets", file_stem("Web"))).is_file());
}

#[test]
fn a_rename_that_only_changes_case_keeps_one_file() {
    let root = fresh_dir("rename-case");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Web"})).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web", "newName": "WEB", "description": "renamed"})).unwrap();

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir.clone());
    assert_eq!(saved_names(&mut b), ["WEB"]);
    assert_eq!(b.prefs.pdf_presets[0].description, "renamed");
    assert_eq!(file_names(&dir), [format!("{}.vcpdfpresets", file_stem("WEB"))]);
}

fn file_names(dir: &std::path::Path) -> Vec<String> {
    std::fs::read_dir(dir).unwrap().map(|e| e.unwrap().file_name().to_string_lossy().into_owned()).collect()
}

/// Windows does not allow replacing a read-only file or writing into it, so the write fails.
#[cfg(windows)]
#[test]
fn a_rename_that_only_changes_case_and_cannot_be_written_keeps_the_old_file() {
    let root = fresh_dir("rename-case-fails");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Web", "description": "for screens"})).unwrap();
    let old = dir.join(format!("{}.vcpdfpresets", file_stem("Web")));
    let writable = std::fs::metadata(&old).unwrap().permissions();
    let mut read_only = writable.clone();
    read_only.set_readonly(true);
    std::fs::set_permissions(&old, read_only).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web", "newName": "WEB"})).unwrap();
    std::fs::set_permissions(&old, writable).unwrap();

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir.clone());
    assert_eq!(saved_names(&mut b), ["Web"]);
    assert_eq!(b.prefs.pdf_presets[0].description, "for screens");
    assert_eq!(file_names(&dir), [format!("{}.vcpdfpresets", file_stem("Web"))]);
}

/// Where file names keep case apart, a folder named like the new file makes the rename fail.
#[cfg(not(any(windows, target_vendor = "apple")))]
#[test]
fn a_rename_that_only_changes_case_and_cannot_be_moved_keeps_the_old_preset() {
    let root = fresh_dir("rename-case-blocked");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Web", "description": "for screens"})).unwrap();
    std::fs::create_dir(dir.join(format!("{}.vcpdfpresets", file_stem("WEB")))).unwrap();
    a.execute("pdf.preset.save", &json!({"name": "Web", "newName": "WEB", "description": "renamed"})).unwrap();

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir.clone());
    assert_eq!(saved_names(&mut b), ["Web"]);
    assert_eq!(b.prefs.pdf_presets[0].description, "for screens");
}

#[test]
fn a_folder_that_does_not_exist_yet_takes_the_presets_the_preferences_held() {
    let root = fresh_dir("seed");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.execute("pdf.preset.save", &json!({"name": "From Preferences"})).unwrap();
    a.attach_pdf_preset_store(dir.clone());
    assert!(dir.is_dir(), "written at once");
    let mut b = Session::new();
    b.attach_pdf_preset_store(dir);
    assert_eq!(saved_names(&mut b), ["From Preferences"]);
}

/// Serves `0` bytes without end and counts how many were read.
struct Endless(u64);

impl std::io::Read for Endless {
    fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
        if self.0 > 1 << 24 {
            return Err(std::io::Error::other("read too far"));
        }
        buf.fill(0);
        self.0 += buf.len() as u64;
        Ok(buf.len())
    }
}

#[test]
fn a_write_reads_the_file_it_replaces_only_one_byte_past_the_new_length() {
    let mut old = Endless(0);
    assert!(!holds(&mut old, &[0; 10]));
    assert_eq!(old.0, 11);
    assert!(holds(&[1, 2, 3][..], &[1, 2, 3]));
    assert!(!holds(&[1, 2, 3, 4][..], &[1, 2, 3]));
    assert!(!holds(&[1, 2][..], &[1, 2, 3]));
    assert!(holds(&[][..], &[]));
}

#[test]
fn a_saved_preset_replaces_an_oversized_file_in_its_place() {
    let root = fresh_dir("oversized-put");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Web"})).unwrap();
    let file = dir.join(format!("{}.vcpdfpresets", file_stem("Web")));
    let saved = std::fs::read(&file).unwrap();
    let mut oversized = saved.clone();
    oversized.resize(usize::try_from(MAX_PRESET_FILE).unwrap() * 2, b' ');
    std::fs::write(&file, &oversized).unwrap();

    a.execute("pdf.preset.save", &json!({"name": "Web"})).unwrap();
    assert_eq!(std::fs::read(&file).unwrap(), saved);
}

#[test]
fn damaged_unsafe_and_oversized_preset_files_are_skipped() {
    let root = fresh_dir("damaged");
    let dir = root.join("PDF Presets");
    let mut a = Session::new();
    a.attach_pdf_preset_store(dir.clone());
    a.execute("pdf.preset.save", &json!({"name": "Good"})).unwrap();
    let write = |name: &str, bytes: &[u8]| std::fs::write(dir.join(name), bytes).unwrap();
    write("a-not-json.vcpdfpresets", b"{ not json");
    write("b-other-format.vcpdfpresets", br#"{"format": "something else", "presets": []}"#);
    let huge = vec![b' '; MAX_PRESET_FILE as usize + 1];
    write("c-huge.vcpdfpresets", &huge);
    write("d-readme.txt", b"ignored");
    let good = std::fs::read_to_string(dir.join(format!("{}.vcpdfpresets", file_stem("Good")))).unwrap();
    // A built-in name, an empty name, a second "good" in another case, and values no export accepts.
    let mut file: Value = serde_json::from_str(&good).unwrap();
    let mut preset = file["presets"][0].clone();
    for name in ["High Quality Print", "  ", "GOOD"] {
        preset["name"] = json!(name);
        file["presets"].as_array_mut().unwrap().push(preset.clone());
    }
    preset["name"] = json!("Bad Values");
    preset["settings"]["advanced"]["fontSubsetPercent"] = json!(500);
    file["presets"].as_array_mut().unwrap().push(preset);
    write("e-mixed.vcpdfpresets", file.to_string().as_bytes());

    let mut b = Session::new();
    b.attach_pdf_preset_store(dir);
    assert_eq!(saved_names(&mut b), ["Good"]);
}

/// An ICC file of an RGB profile named `name` (a built-in one with its description replaced by a
/// name of the same length).
fn icc_named(name: &str) -> Vec<u8> {
    let builtin = cms::DISPLAY_P3;
    assert_eq!(builtin.len(), name.len());
    let utf16 = |s: &str| s.encode_utf16().flat_map(u16::to_be_bytes).collect::<Vec<u8>>();
    let mut bytes = cms::icc_bytes(builtin).unwrap().to_vec();
    let (from, to) = (utf16(builtin), utf16(name));
    let at = bytes.windows(from.len()).position(|w| w == from).unwrap();
    bytes[at..at + to.len()].copy_from_slice(&to);
    bytes
}

#[test]
fn stored_profiles_register_again_and_removing_one_removes_its_copy() {
    let root = fresh_dir("profiles");
    let dir = root.join("Color Profiles");
    std::fs::create_dir_all(&dir).unwrap();
    let name = "StoreRGB-1";
    let file = format!("{}.icc", file_stem(name));
    std::fs::write(dir.join("junk.icc"), b"not a profile").unwrap();
    std::fs::write(dir.join("empty.icc"), b"").unwrap();
    std::fs::write(dir.join(&file), icc_named(name)).unwrap();
    assert!(cms::profile(name).is_none());

    let mut s = Session::new();
    s.attach_profile_store(dir.clone());
    assert!(cms::profile(name).is_some_and(|p| !p.builtin), "registered from the store");

    // A profile loaded from elsewhere is copied in, whatever the file is called.
    let other = "StoreRGB-2";
    let loose_dir = vectorcraft_testkit::TempDir::new("store-loose");
    let loose = loose_dir.join("whatever.icm");
    std::fs::write(&loose, icc_named(other)).unwrap();
    let r = s.execute("color.loadProfile", &json!({"path": loose.to_str().unwrap()})).unwrap();
    assert_eq!((r["name"].as_str(), r["remembered"].as_bool()), (Some(other), Some(true)));
    std::fs::remove_file(&loose).unwrap();
    assert_eq!(std::fs::read(dir.join(format!("{}.icc", file_stem(other)))).unwrap(), icc_named(other));

    let r = s.execute("color.removeProfile", &json!({"name": name})).unwrap();
    assert_eq!(r["removed"], name);
    assert!(cms::profile(name).is_none() && !dir.join(&file).exists());
    assert!(s.execute("color.removeProfile", &json!({"name": name})).is_err(), "already gone");
    assert!(s.execute("color.removeProfile", &json!({"name": cms::SRGB})).is_err(), "built-in profiles stay");
    s.execute("color.removeProfile", &json!({"name": other})).unwrap();
}