GitCorner

Code

ossartcraftvectorcraft🌐
2bc41aeb8602
//! Every arrowhead's outline: drawn, inside its reach and half width (4 × 4 weights for most; the
//! open arrow's square-cut arms reach a little further back, the line arrow's twice as far out),
//! without self-intersections, and covering the end of the stroke under it.

use kurbo::{BezPath, PathEl, Point, Shape};
use vectorcraft_color::{Color, Paint};
use vectorcraft_doc::{ArrowAlign, Arrowhead, StrokeLayer};

use super::stroke_pieces;

/// A 2 pt line along +x ending at (100, 0) with `kind` at its end, tip on the end point: heads
/// of weight 2, so 8 long and 8 wide.
fn head(kind: Arrowhead) -> super::Arrow {
    let mut st = StrokeLayer::new(Paint::solid(Color::BLACK), 2.0);
    st.end_arrow = Some(kind);
    st.arrow_align = ArrowAlign::Tip;
    let mut l = BezPath::new();
    l.move_to((0.0, 0.0));
    l.line_to((100.0, 0.0));
    stroke_pieces(&l, &st).heads.remove(0)
}

/// The outline's closed contours as polygons (curves flattened).
fn contours(bp: &BezPath) -> Vec<Vec<Point>> {
    let mut out: Vec<Vec<Point>> = vec![];
    kurbo::flatten(bp.iter(), 1e-3, |el| match el {
        PathEl::MoveTo(p) => out.push(vec![p]),
        PathEl::LineTo(p) => out.last_mut().unwrap().push(p),
        PathEl::ClosePath => {
            let c = out.last_mut().unwrap();
            if c.len() > 1 && c[0].distance(*c.last().unwrap()) < 1e-9 {
                c.pop();
            }
        }
        _ => panic!("flattened"),
    });
    out
}

/// Do segments `a` and `b` cross at a point inside both (touching ends don't count)?
fn cross(a: (Point, Point), b: (Point, Point)) -> bool {
    let orient = |p: Point, q: Point, r: Point| (q - p).cross(r - p);
    let (d1, d2) = (orient(b.0, b.1, a.0), orient(b.0, b.1, a.1));
    let (d3, d4) = (orient(a.0, a.1, b.0), orient(a.0, a.1, b.1));
    d1 * d2 < -1e-12 && d3 * d4 < -1e-12
}

#[test]
fn every_outline_is_drawn_inside_its_box_without_self_intersections() {
    let (o, d) = (Point::ORIGIN, Point::new(2.0, 2.0));
    assert!(cross((o, d), (Point::new(0.0, 2.0), Point::new(2.0, 0.0))) && !cross((o, d), (d, Point::new(4.0, 0.0))), "the check itself");
    for kind in Arrowhead::ALL {
        let h = head(kind.clone());
        assert!(h.outline.area().abs() > 4.0, "{kind:?} is drawn");
        let b = h.outline.bounding_box();
        let (reach, side) = (2.0 * kind.reach(), 2.0 * kind.half_width());
        assert!(b.x1 <= 100.0 + 1e-6 && b.y0 >= -side - 1e-6 && b.y1 <= side + 1e-6, "{kind:?} leaves its box: {b:?}");
        if kind.half_width() == 2.0 {
            assert!(b.x0 >= 91.0 - 1e-6, "{kind:?} is longer than the 4 × 4 box: {b:?}");
        }
        let far = contours(&h.outline).iter().flatten().map(|p| p.distance(h.tip)).fold(0.0, f64::max);
        assert!(far <= reach + 1e-6, "{kind:?} reaches {far} from its tip, past {reach}");
        let edges: Vec<(Point, Point)> = contours(&h.outline).iter().flat_map(|c| (0..c.len()).map(|i| (c[i], c[(i + 1) % c.len()]))).collect();
        assert!(edges.len() >= 3, "{kind:?}");
        for (i, a) in edges.iter().enumerate() {
            for b in &edges[i + 1..] {
                assert!(!cross(*a, *b), "{kind:?}: {a:?} crosses {b:?}");
            }
        }
    }
}

#[test]
fn the_stroke_ends_inside_every_head() {
    for kind in Arrowhead::ALL {
        let h = head(kind.clone());
        // Just in front of where the line stops, on its centre line.
        let end = h.tip - h.dir * (h.inset - 0.1);
        assert_ne!(h.outline.winding(end), 0, "{kind:?}: the line ends outside the head (inset {})", h.inset);
    }
}

#[test]
fn the_line_arrow_is_a_right_angle_of_two_arms_as_thick_as_the_line() {
    // Weight 2 at 100 %: a local unit (x back from the tip, y across) is 2 pt.
    let h = head(Arrowhead::LineArrow);
    let at = |x: f64, y: f64| Point::new(100.0 - 2.0 * x, 2.0 * y);
    // A sharp tip on the end point; outer corners 4 units back and out, square-cut ends.
    let pts: Vec<Point> = contours(&h.outline).concat();
    for (corner, name) in [(at(0.0, 0.0), "tip"), (at(4.0, 4.0), "right corner"), (at(4.0, -4.0), "left corner")] {
        assert!(pts.iter().any(|p| p.distance(corner) < 1e-9), "{name} {corner:?} in {pts:?}");
    }
    // Open between the arms, solid at the tip.
    assert_eq!(h.outline.winding(at(2.5, 0.0)), 0);
    assert_ne!(h.outline.winding(at(0.7, 0.0)), 0);
    // Halfway along each arm, 45° off the line, it is one unit (the line's weight) across.
    let s = std::f64::consts::FRAC_1_SQRT_2;
    for side in [1.0, -1.0] {
        let (mx, my) = (2.0 + 0.5 * s, side * (2.0 - 0.5 * s));
        let (nx, ny) = (-side * s, s);
        for (d, inside) in [(0.45, true), (-0.45, true), (0.55, false), (-0.55, false)] {
            let w = h.outline.winding(at(mx + nx * d, my + ny * d));
            assert_eq!(w != 0, inside, "arm {side} at {d} across");
        }
    }
}

#[test]
fn half_arrows_barb_on_their_own_side() {
    // Pointing along +x on a y-down page, left is −y.
    assert!(head(Arrowhead::HalfArrowLeft).outline.bounding_box().y0 < -3.0);
    assert!(head(Arrowhead::HalfArrowLeft).outline.bounding_box().y1 < 1.5);
    assert!(head(Arrowhead::HalfArrowRight).outline.bounding_box().y1 > 3.0);
}

#[test]
fn custom_heads_draw_their_own_art_at_the_tip() {
    use vectorcraft_doc::CustomArrowhead;
    use vectorcraft_geom::{PathData, SubPath};
    // From the tip back 3 units, 2 to the right of the line and 1 to the left.
    let wedge = PathData::single(SubPath::polyline(&[Point::new(0.0, 0.0), Point::new(3.0, 2.0), Point::new(3.0, -1.0)], true));
    let kind = Arrowhead::Custom(std::sync::Arc::new(CustomArrowhead::new("Wedge".into(), wedge)));
    let h = head(kind.clone());
    // Weight 2: drawn back to x 94, right of +x is +y on a y-down page.
    let b = h.outline.bounding_box();
    assert!((b.x0 - 94.0).abs() < 1e-9 && (b.x1 - 100.0).abs() < 1e-9 && (b.y0 + 2.0).abs() < 1e-9 && (b.y1 - 4.0).abs() < 1e-9, "{b:?}");
    assert_eq!(h.outline.winding(Point::new(95.0, 1.0)), h.outline.winding(Point::new(95.0, 0.5)));
    assert_ne!(h.outline.winding(Point::new(95.0, 1.0)), 0);
    // The line stops halfway along the head.
    assert!((h.inset - 3.0).abs() < 1e-9, "inset {}", h.inset);
    // Extended, the tip sits the inset past the end point, and scaling scales the art.
    let mut st = StrokeLayer::new(Paint::solid(Color::BLACK), 2.0);
    (st.start_arrow, st.arrow_scale) = (Some(kind), (200.0, 100.0));
    let mut l = BezPath::new();
    l.move_to((0.0, 0.0));
    l.line_to((100.0, 0.0));
    let p = stroke_pieces(&l, &st);
    let [s] = &p.heads[..] else { panic!("one head") };
    assert!((s.tip.x + 6.0).abs() < 1e-9 && s.dir.x < 0.0, "tip {:?}", s.tip);
    assert!((s.outline.bounding_box().width() - 12.0).abs() < 1e-9);
}