856f865cf98d
links.rs
//! Community and project links: the Help menu, the About dialog, the start screen and the title
//! bar all open these. URLs follow the crafting-app pattern (`getartcraft.com/apps/<app>`,
//! `github.com/storytold/<app>`).
use serde_json::{Value, json};
use crate::PhotocraftApp;
pub const DISCORD: &str = "https://discord.gg/artcraft";
pub const ARTCRAFT_WEBSITE: &str = "https://getartcraft.com";
pub const APP_PAGE: &str = "https://getartcraft.com/apps/photocraft";
pub const TUTORIALS: &str = "https://getartcraft.com/tutorials";
pub const GITHUB: &str = "https://github.com/storytold/photocraft";
pub const ISSUES: &str = "https://github.com/storytold/photocraft/issues";
/// Help-menu link commands: (id, url). Labels live in `menus::UI_COMMANDS`.
pub const COMMANDS: &[(&str, &str)] =
&[("help.discord", DISCORD), ("help.website", APP_PAGE), ("help.artcraftWebsite", ARTCRAFT_WEBSITE), ("help.github", GITHUB), ("help.reportIssue", ISSUES)];
pub fn url_for(id: &str) -> Option<&'static str> {
COMMANDS.iter().find(|c| c.0 == id).map(|c| c.1)
}
/// Open `url` in the system browser (a new tab on the web) and note it in the status bar. Prefers
/// the platform `open_url` service (reliable on Windows/macOS/Linux); falls back to `ctx.open_url`.
pub fn open(app: &mut PhotocraftApp, ctx: &egui::Context, url: &str) -> Value {
let opened = app.services.open_url.as_ref().map(|f| f(url).is_ok()).unwrap_or(false);
if !opened {
ctx.open_url(egui::OpenUrl::new_tab(url));
}
let template = "Opened {url}";
app.ui.status = crate::i18n::fmt(tl!(template), &[("url", url)]);
json!({"url": url})
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn links_open_through_the_platform_service() {
// Issue #14: links (Help menu, Discord button, start-page links) must open in the browser.
// They route through the `open_url` service rather than the unreliable `ctx.open_url`.
use std::sync::{Arc, Mutex};
let opened: Arc<Mutex<Vec<String>>> = Arc::new(Mutex::new(Vec::new()));
let rec = opened.clone();
let services = crate::Services {
open_url: Some(Box::new(move |u: &str| {
rec.lock().unwrap().push(u.to_string());
Ok(())
})),
..Default::default()
};
let mut app = PhotocraftApp::new(photocraft_engine::Session::new(), services);
let ctx = app.ctx().clone();
// Every Help-menu link id reaches the service with its URL.
for (id, url) in COMMANDS {
crate::menus::invoke(&mut app, &ctx, id, json!({})).unwrap();
assert_eq!(opened.lock().unwrap().last().map(String::as_str), Some(*url), "{id}");
}
// The direct open() helper (Discord button / start-page links) also uses it.
open(&mut app, &ctx, DISCORD);
assert_eq!(opened.lock().unwrap().last().map(String::as_str), Some(DISCORD));
}
}
No file is open. Choose one in the tree, or press Ctrl+O (⌘O on a Mac) to find one by name.
Syntax highlighting could not load. The unmodified read-only text remains available above.