GitCorner

Code

ossartcraftlightcraft🌐
5a24289898fd
//! Asset attribution check (AGENTS.md "Assets" rule): every image, icon, font, sound, video, raw
//! file or colour profile in the repository must be covered by a path pattern in the first column of
//! `assets/ATTRIBUTION.md`, licence files referenced there must exist, and nothing may look like it
//! came from an Adobe product.

use std::path::Path;
use std::process::Command;

/// Extensions treated as assets (lower-case).
const ASSET_EXT: &[&str] = &[
    "png", "jpg", "jpeg", "gif", "webp", "avif", "svg", "ico", "icns", "bmp", "ttf", "otf", "woff", "woff2", "wav", "mp3", "ogg", "flac", "mp4",
    "mov", "tif", "tiff", "dng", "cr2", "cr3", "nef", "arw", "raf", "orf", "rw2", "rwl", "raw", "pef", "srw", "heic", "jxl", "psd", "cube", "icc",
    "icm", "xmp",
];
/// Adobe-specific formats we never ship (camera/lens profiles, Lightroom templates).
const FORBIDDEN_EXT: &[&str] = &["dcp", "lcp", "lrtemplate", "lrcat", "lrsmcol", "aco", "ase", "abr"];
const FORBIDDEN_NAME: &[&str] = &["adobe", "lightroom", "photoshop", "creative cloud", "creativecloud"];

/// `*` matches any run of characters except `/`; a pattern ending in `/` matches everything below it.
pub fn glob(pat: &str, path: &str) -> bool {
    if let Some(dir) = pat.strip_suffix('/') {
        return path.starts_with(dir) && path[dir.len()..].starts_with('/');
    }
    // (pattern, path) positions already found not to match: each is tried once, so overlapping
    // `*`s can't make the search exponential
    fn rec(p: &[u8], s: &[u8], failed: &mut std::collections::HashSet<(usize, usize)>) -> bool {
        if failed.contains(&(p.len(), s.len())) {
            return false;
        }
        let ok = match (p.first(), s.first()) {
            (None, None) => true,
            (Some(b'*'), _) => rec(&p[1..], s, failed) || (!s.is_empty() && s[0] != b'/' && rec(p, &s[1..], failed)),
            (Some(a), Some(b)) if a == b => rec(&p[1..], &s[1..], failed),
            _ => false,
        };
        if !ok {
            failed.insert((p.len(), s.len()));
        }
        ok
    }
    rec(pat.as_bytes(), path.as_bytes(), &mut std::collections::HashSet::new())
}

fn backticked(cell: &str) -> impl Iterator<Item = &str> {
    cell.split('`').skip(1).step_by(2)
}

/// (path patterns, referenced licence files) from the attribution table.
pub fn parse(md: &str) -> (Vec<String>, Vec<String>) {
    let (mut pats, mut licences) = (Vec::new(), Vec::new());
    for line in md.lines().filter(|l| l.trim_start().starts_with('|')) {
        let cells: Vec<&str> = line.trim().trim_matches('|').split('|').collect();
        if cells.len() < 5 {
            continue;
        }
        pats.extend(backticked(cells[0]).filter(|p| p.contains('/')).map(str::to_string));
        licences.extend(backticked(cells[4]).filter(|p| p.contains('/')).map(str::to_string));
    }
    (pats, licences)
}

/// Problems with `files` given the attribution document `md`; `exists` checks licence files.
pub fn check(files: &[String], md: &str, exists: impl Fn(&str) -> bool) -> Vec<String> {
    let (pats, licences) = parse(md);
    let mut out = Vec::new();
    for f in files {
        let lower = f.to_ascii_lowercase();
        let ext = Path::new(&lower).extension().and_then(|e| e.to_str()).unwrap_or("");
        let name = Path::new(&lower).file_name().and_then(|e| e.to_str()).unwrap_or("");
        if FORBIDDEN_EXT.contains(&ext) {
            out.push(format!("{f}: `.{ext}` files (Adobe profile/template formats) must never be committed"));
            continue;
        }
        if !ASSET_EXT.contains(&ext) {
            continue;
        }
        if FORBIDDEN_NAME.iter().any(|n| name.contains(n)) {
            out.push(format!("{f}: asset name suggests Adobe material; Adobe assets are forbidden (AGENTS.md)"));
        }
        if !pats.iter().any(|p| glob(p, f)) {
            out.push(format!("{f}: no entry in assets/ATTRIBUTION.md (add path, creator, source, licence, date, modifications)"));
        }
    }
    for l in licences {
        if !exists(&l) {
            out.push(format!("assets/ATTRIBUTION.md references missing licence file `{l}`"));
        }
    }
    out
}

pub fn run(root: &Path) -> Result<(), String> {
    let out = Command::new("git")
        .args(["ls-files", "--cached", "--others", "--exclude-standard"])
        .current_dir(root)
        .output()
        .map_err(|e| format!("git ls-files: {e}"))?;
    if !out.status.success() {
        return Err("git ls-files failed".into());
    }
    let files: Vec<String> = String::from_utf8_lossy(&out.stdout).lines().filter(|f| root.join(f).exists()).map(str::to_string).collect();
    let md = std::fs::read_to_string(root.join("assets/ATTRIBUTION.md")).map_err(|e| format!("assets/ATTRIBUTION.md: {e}"))?;
    let problems = check(&files, &md, |p| root.join(p).exists());
    if problems.is_empty() {
        let n = files
            .iter()
            .filter(|f| Path::new(&f.to_ascii_lowercase()).extension().and_then(|e| e.to_str()).is_some_and(|e| ASSET_EXT.contains(&e)))
            .count();
        eprintln!("assets: {n} asset files, all attributed");
        Ok(())
    } else {
        Err(format!("asset rule violations:\n  {}", problems.join("\n  ")))
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    const MD: &str = "| Path | Asset | Creator | Source | Licence | Added | Mods |\n|---|---|---|---|---|---|---|\n\
        | `assets/fonts/Foo-*.ttf` | Foo | A | url | OFL (`assets/fonts/OFL-Foo.txt`) | d | none |\n\
        | `crates/scenes/` | gen | us | original | MIT | d | n/a |\n";

    #[test]
    fn globbing() {
        assert!(glob("docs/images/*-tetons.jpg", "docs/images/ba-tetons.jpg"));
        assert!(!glob("docs/images/*.jpg", "docs/images/sub/x.jpg"));
        assert!(glob("crates/scenes/", "crates/scenes/a/b.png"));
        // forty `*` against a long name that fails at its very end: exponential without the memo
        let pat = format!("{}x", "*a".repeat(40));
        let name = "a".repeat(200);
        let t = std::time::Instant::now();
        assert!(!glob(&pat, &name));
        assert!(t.elapsed().as_secs() < 5, "took {:?}", t.elapsed());
        assert!(glob("*a*b*", "xaybz") && !glob("*a*b*", "xa/b"));
        assert!(!glob("crates/scenes/", "crates/scenesx/b.png"));
    }

    #[test]
    fn flags_unattributed_forbidden_and_missing_licence() {
        let files: Vec<String> =
            ["assets/fonts/Foo-Bold.ttf", "assets/icons/x.svg", "crates/scenes/t.png", "src/lib.rs", "p/camera.dcp", "assets/fonts/Adobe-Foo.otf"]
                .map(String::from)
                .into();
        let p = check(&files, MD, |_| false);
        assert!(p.iter().any(|m| m.starts_with("assets/icons/x.svg: no entry")));
        assert!(p.iter().any(|m| m.starts_with("p/camera.dcp")));
        assert!(p.iter().any(|m| m.contains("Adobe-Foo.otf: asset name")));
        assert!(p.iter().any(|m| m.contains("OFL-Foo.txt")));
        assert!(!p.iter().any(|m| m.starts_with("assets/fonts/Foo-Bold.ttf") || m.starts_with("crates/scenes") || m.starts_with("src/")));
    }
}