5a24289898fd
edit.rs
//! The Edit panel: histogram, Auto/B&W, profile, and the Light / Color / Effects / Detail / Optics
//! sections, built from the engine's control specs.
use egui::epaint::{Mesh, Vertex};
use egui::{Align2, Color32, Pos2, Rect, RichText, Sense, Stroke, pos2, vec2};
use lightcraft_catalog::PhotoId;
use lightcraft_develop::{ControlSpec, DevelopSettings, Section, Track, WbMode, controls};
use lightcraft_geom::Point;
use lightcraft_pipeline::{PARAM_AMOUNTS, ParametricCurve};
use lightcraft_raster::Histogram;
use serde_json::{Value, json};
use crate::LightcraftApp;
use crate::icons::{Icon, paint};
use crate::render::Slot;
use crate::state::RightPanel;
use crate::theme::Tokens;
use crate::widgets::{BAND_COLORS, SliderOut, divider, flyout_row, hex, register, section_header, slider, text_button};
mod curve;
mod grading;
mod hdr_flow;
mod histogram;
mod lens_blur;
mod mixer;
mod sliders;
use curve::curve_editor;
use grading::grading;
pub(crate) use grading::wheel_pointer_frame_end;
#[cfg(test)]
pub(crate) use grading::{WheelGrab, WheelLock, WheelMods, wheel_pick};
pub(crate) use histogram::histogram;
use histogram::soft_proofing;
use lens_blur::lens_blur;
use mixer::{mixer, point_color};
use sliders::{REL_TEMP, REL_TINT, hdr_row, header_buttons, k_to_rel, profile_menu, quick_develop, rel_to_k, reset_tip, section};
pub use sliders::{apply_slider_out, sub_title};
pub(crate) use sliders::{control, reload_preview_only};
pub fn show(app: &mut LightcraftApp, ui: &mut egui::Ui, id: PhotoId) {
let t = Tokens::get(ui.ctx());
let d = app.session.develop_of(id).unwrap_or_default();
// a raw shown from its embedded JPEG (preview only) gets the rendered-file white balance scale
let raw = app.session.catalog.photo(id).is_some_and(|p| p.develops_raw() && !p.relative_wb());
let mut d = d;
if d.wb.mode == WbMode::AsShot && app.session.catalog.photo(id).is_some_and(|p| p.relative_wb()) {
let wb = &mut std::sync::Arc::make_mut(&mut d).wb;
wb.temp = 6500.0;
wb.tint = 0.0;
} else if raw {
// the Kelvin sliders show the white balance in effect: As Shot reads the file's as-shot white (the stored
// numbers can predate a decoder update, or the camera's matrices giving the file its Kelvin scale), a
// preset its Kelvin value, and a value written on the old relative scale the Kelvin it renders as
let info = app.session.source_info(id);
let (temp, tint) = lightcraft_engine::pipeline::local::effective_wb(&info, &d);
let wb = &mut std::sync::Arc::make_mut(&mut d).wb;
wb.temp = temp;
wb.tint = tint;
}
let preview_only = app.session.catalog.photo(id).and_then(|p| p.preview_only.clone());
if app.ui.soft_proof {
soft_proofing(app, ui, id);
}
// header: Edit + Auto / B&W / HDR
let mut reset_clicked = false;
let (hr, _) = ui.allocate_exact_size(vec2(ui.available_width(), 40.0), Sense::hover());
ui.painter().text(pos2(hr.left() + 24.0, hr.bottom() - 10.0), Align2::LEFT_CENTER, crate::i18n::tr("Edit"), t.semibold(15.0), t.text);
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 8, bottom: 14 }).show(ui, |ui| {
let tip = reset_tip(&app.ui.settings.keymap, ui.ctx().os() == egui::os::OperatingSystem::Mac);
let clicks = header_buttons(ui, crate::is_bw(&d), d.hdr.enabled, &tip);
if clicks.auto {
let _ = app.run("develop.auto", json!({}));
app.toast(ui.ctx(), crate::i18n::tr("Auto settings applied"));
}
if clicks.bw {
let _ = app.run("develop.treatment", json!({}));
}
if clicks.hdr {
let _ = app.run("develop.hdr", json!({"enabled": !d.hdr.enabled}));
}
reset_clicked = clicks.reset;
});
if let Some(why) = &preview_only {
let reload = egui::Frame::NONE
.inner_margin(egui::Margin { left: 24, right: 22, top: 0, bottom: 12 })
.show(ui, |ui| crate::widgets::preview_only_notice(ui, "edit", why))
.inner;
if reload {
reload_preview_only(app, ui.ctx(), id);
}
}
let n = app.session.selection.ids.len();
if n > 1 && matches!(app.ui.view, crate::state::ViewMode::PhotoGrid | crate::state::ViewMode::SquareGrid) {
quick_develop(app, ui, n);
}
if app.session.auto_sync && n > 1 {
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 0, bottom: 10 }).show(ui, |ui| {
ui.horizontal(|ui| {
ui.label(egui::RichText::new(crate::i18n::tr_format!("Auto Sync: edits apply to {n} photos", n = n)).color(t.accent).size(12.0));
ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| {
if text_button(ui, "autoSyncOff", crate::i18n::tr("Turn Off"), false).clicked() {
let _ = app.run("develop.autoSync", json!({"on": false}));
}
});
});
});
}
divider(ui);
// profile row
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 14, bottom: 14 }).show(ui, |ui| {
ui.horizontal(|ui| {
ui.label(egui::RichText::new(crate::i18n::tr("Profile")).font(t.font(13.0)).color(t.text_dim));
let name = app.session.profile_info(&d.profile.id).map(|(name, _)| name).unwrap_or("Color");
// a long name is cut short before Browse Profiles: a wider row would widen the whole panel's
// content, and the sliders below would run past its edge
let max = ui.available_width() - 28.0 - ui.spacing().item_spacing.x;
let r = crate::widgets::dropdown_within(ui, "profile", crate::i18n::profile_label(&d.profile.id, name), t.font(15.0), t.text_label, max);
let below = r.rect.bottom();
egui::Popup::menu(&r).show(|ui| profile_menu(app, ui, &d, below));
ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| {
if crate::widgets::icon_button(
ui,
"profileBrowser",
Icon::ProfileGrid,
vec2(28.0, 28.0),
false,
true,
crate::i18n::tr("Browse Profiles"),
)
.clicked()
{
let _ = app.run("panel.profiles", json!({}));
}
});
});
});
if d.profile.id != "lc.color" {
control(app, ui, &d, "profile.amount", true);
ui.add_space(6.0);
}
// a raw carrying its own local tone mapping (Apple ProRAW's gain table map): off renders it as
// Lightroom Classic does, on as the camera does
if app.session.source_info(id).local_tone.is_some() {
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 0, bottom: 10 }).show(ui, |ui| {
let mut on = d.profile.camera_local_tone;
let r = ui.checkbox(&mut on, crate::i18n::tr("Camera local tone mapping"));
crate::widgets::register(ui, "check:profile.cameraLocalTone", r.rect);
if r.on_hover_text(crate::i18n::tr("Apply the local tone mapping stored in the raw (Apple ProRAW), as the camera renders it")).changed() {
let _ = app.run("develop.merge", json!({"settings": {"profile": {"camera_local_tone": on}}, "label": "Camera Local Tone Mapping"}));
}
});
}
divider(ui);
section(app, ui, &d, "light", "Light", |app, ui, d| {
hdr_row(app, ui, d, id);
for c in ["light.exposure", "light.contrast", "light.highlights", "light.shadows", "light.whites", "light.blacks"] {
control(app, ui, d, c, true);
}
ui.add_space(6.0);
if d.hdr.enabled {
let open = app.ui.flyout_open("sdrRendition");
if flyout_row(ui, "sdrRendition", "SDR Rendition", Icon::Sliders, open).clicked() {
app.ui.toggle_flyout("sdrRendition");
}
if open {
for c in ["hdr.sdrBrightness", "hdr.sdrContrast", "hdr.sdrHighlights", "hdr.sdrShadows", "hdr.sdrWhites", "hdr.sdrClarity"] {
control(app, ui, d, c, true);
}
ui.add_space(6.0);
}
}
let open = app.ui.flyout_open("curve");
if flyout_row(ui, "curve", crate::i18n::tr("Curve"), Icon::Curve, open).clicked() {
app.ui.toggle_flyout("curve");
}
if open {
curve_editor(app, ui, id, d);
}
ui.add_space(8.0);
});
section(app, ui, &d, "color", "Color", |app, ui, d| {
// White balance row
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 2, bottom: 2 }).show(ui, |ui| {
ui.horizontal(|ui| {
ui.label(egui::RichText::new(crate::i18n::tr("White Balance")).font(t.font(13.0)).color(t.text_dim));
let r = crate::widgets::dropdown(ui, "wbMode", crate::i18n::tr(d.wb.mode.label()), t.font(14.0), t.text_label);
egui::Popup::menu(&r).show(|ui| {
for m in WbMode::ALL {
if m == WbMode::Custom {
continue;
}
if ui.selectable_label(d.wb.mode == m, crate::i18n::tr(m.label())).clicked() {
let mode = serde_json::to_value(m).unwrap_or_default();
let _ = app.run("develop.wb", json!({"mode": mode}));
}
}
});
ui.with_layout(egui::Layout::right_to_left(egui::Align::Center), |ui| {
let active = app.ui.tool == "wbPicker";
if crate::widgets::icon_button(
ui,
"wbPicker",
Icon::Picker,
vec2(28.0, 28.0),
active,
true,
crate::i18n::tr("White Balance Selector (W)"),
)
.clicked()
{
if active {
app.ui.tool.clear();
} else if let Err(e) = app.run("tool.wbPicker", json!({})) {
// the same as W: from Compare, Survey or the grid it opens the photo in Detail
app.toast(ui.ctx(), e);
}
}
});
});
});
if raw {
control(app, ui, d, "wb.temp", true);
control(app, ui, d, "wb.tint", true);
} else {
let out = slider(ui, &REL_TEMP, k_to_rel(d.wb.temp), true, None);
apply_slider_out(app, &REL_TEMP, out, |app, v| app.run("develop.set", json!({"control": "wb.temp", "value": rel_to_k(v)})));
let out = slider(ui, &REL_TINT, d.wb.tint.clamp(-100.0, 100.0), true, None);
apply_slider_out(app, &REL_TINT, out, |app, v| app.run("develop.set", json!({"control": "wb.tint", "value": v})));
}
control(app, ui, d, "color.vibrance", true);
control(app, ui, d, "color.saturation", true);
ui.add_space(6.0);
let open = app.ui.flyout_open("mixer");
if flyout_row(ui, "mixer", if crate::is_bw(d) { "B&W Mixer" } else { "Color Mixer" }, Icon::Radial, open).clicked() {
app.ui.toggle_flyout("mixer");
}
if open {
mixer(app, ui, d);
}
if !crate::is_bw(d) {
let open = app.ui.flyout_open("pointColor");
if flyout_row(ui, "pointColor", crate::i18n::tr("Point Color"), Icon::Picker, open).clicked() {
app.ui.toggle_flyout("pointColor");
}
if open {
point_color(app, ui, d);
}
}
let open = app.ui.flyout_open("grading");
if flyout_row(ui, "grading", crate::i18n::tr("Color Grading"), Icon::Presets, open).clicked() {
app.ui.toggle_flyout("grading");
}
if open {
grading(app, ui, d, id);
}
ui.add_space(8.0);
});
section(app, ui, &d, "effects", "Effects", |app, ui, d| {
for c in ["effects.texture", "effects.clarity", "effects.dehaze"] {
control(app, ui, d, c, true);
}
sub_title(ui, crate::i18n::tr("Vignette"));
{
use lightcraft_develop::VignetteStyle as V;
let styles = [
(V::HighlightPriority, "Highlight", "highlightPriority"),
(V::ColorPriority, "Color", "colorPriority"),
(V::PaintOverlay, "Paint", "paintOverlay"),
];
let items: Vec<(&str, &str)> = styles.iter().map(|(_, l, k)| (*l, *k)).collect();
let active = styles.iter().position(|(v, _, _)| *v == d.vignette.style);
let mut chosen = None;
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 2, bottom: 4 }).show(ui, |ui| {
chosen = crate::widgets::segmented(ui, "vignetteStyle", &items, active, 3);
});
if let Some(i) = chosen {
let _ = app.run(
"develop.merge",
serde_json::json!({"settings": {"vignette": {"style": serde_json::to_value(styles[i].0).unwrap_or_default()}}}),
);
}
}
for c in ["vignette.amount", "vignette.midpoint", "vignette.feather", "vignette.roundness", "vignette.highlights"] {
let enabled = c == "vignette.amount" || d.vignette.amount != 0.0;
control(app, ui, d, c, enabled);
}
sub_title(ui, crate::i18n::tr("Grain"));
for c in ["grain.amount", "grain.size", "grain.roughness"] {
control(app, ui, d, c, c == "grain.amount" || d.grain.amount != 0.0);
}
ui.add_space(8.0);
});
section(app, ui, &d, "detail", "Detail", |app, ui, d| {
for c in ["detail.sharpenAmount", "detail.sharpenRadius", "detail.sharpenDetail", "detail.sharpenMasking"] {
control(app, ui, d, c, c == "detail.sharpenAmount" || d.detail.sharpen_amount > 0.0);
}
// AI Denoise is its own tool, apart from the manual noise reduction sliders below it
sub_title(ui, crate::i18n::tr("AI Denoise"));
// AI Denoise: how much of the photo's cleaned picture to mix in (raw files only), and what that picture is doing
let applicable = !matches!(app.session.denoise_photo_state(id), lightcraft_engine::denoise::PhotoState::NotApplicable);
let on = d.enhance.denoise_enabled();
super::denoise::detail_toggle(app, ui, id, on, applicable);
control(app, ui, d, "enhance.denoise", applicable && on);
super::denoise::detail_status(app, ui, id, if on { d.enhance.denoise } else { 0.0 });
sub_title(ui, crate::i18n::tr("Noise Reduction"));
for c in ["detail.nrLuminance", "detail.nrDetail", "detail.nrContrast", "detail.nrColor", "detail.nrColorDetail", "detail.nrColorSmoothness"]
{
control(app, ui, d, c, true);
}
// single outlier photosites, replaced in the raw mosaic (#1345): raws only
if app.session.catalog.photo(id).is_some_and(|p| p.develops_raw()) {
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 4, bottom: 0 }).show(ui, |ui| {
let mut on = d.detail.nr_outliers;
if crate::dialogs::settings::check(ui, "detail.nrOutliers", &mut on, "Remove Hot Pixels") {
let _ = app.run("develop.merge", json!({"settings": {"detail": {"nr_outliers": on}}, "label": "Remove Hot Pixels"}));
}
});
}
ui.add_space(8.0);
});
section(app, ui, &d, "optics", "Optics", |app, ui, d| {
let has_lens = app.session.catalog.photo(id).is_some_and(|p| p.embedded_lens.is_some());
egui::Frame::NONE.inner_margin(egui::Margin { left: 24, right: 22, top: 4, bottom: 4 }).show(ui, |ui| {
let mut ca = d.optics.remove_ca;
if ui.checkbox(&mut ca, crate::i18n::tr("Remove Chromatic Aberration")).changed() {
let _ = app.run("develop.merge", json!({"settings": {"optics": {"remove_ca": ca}}, "label": "Remove CA"}));
}
let mut lp = d.optics.lens_profile;
if ui.checkbox(&mut lp, crate::i18n::tr("Enable Lens Corrections")).changed() {
let ok = app.run("develop.merge", json!({"settings": {"optics": {"lens_profile": lp}}, "label": "Lens Corrections"})).is_ok();
// ticked on photos without a profile: look their lenses up again (a database that arrived
// since they were imported may know them now)
if ok && lp {
let without = crate::lens_db::to_look_up(&app.session, id);
app.ui.lens_lookup_ids.extend(without);
}
}
if lp && let Some(p) = app.session.catalog.photo(id).cloned() {
let text = crate::lens_db::readout(app, &p);
if !text.is_empty() {
let r = ui.label(egui::RichText::new(text).size(11.0).color(Tokens::get(ui.ctx()).text_dim));
crate::widgets::register(ui, "optics:lensProfile", r.rect);
}
}
});
if d.optics.lens_profile {
for c in ["optics.profileDistortion", "optics.profileVignetting"] {
control(app, ui, d, c, has_lens);
}
}
sub_title(ui, crate::i18n::tr("Manual"));
for c in ["optics.distortion", "optics.vignetting"] {
control(app, ui, d, c, true);
}
control(app, ui, d, "optics.vignettingMidpoint", d.optics.vignetting != 0.0);
ui.add_space(6.0);
let open = app.ui.flyout_open("defringe");
if flyout_row(ui, "defringe", crate::i18n::tr("Defringe"), Icon::Picker, open).clicked() {
app.ui.toggle_flyout("defringe");
}
if open {
control(app, ui, d, "optics.defringePurple", true);
let on = d.optics.defringe_purple_amount > 0.0;
control(app, ui, d, "optics.defringePurpleHueLo", on);
control(app, ui, d, "optics.defringePurpleHueHi", on);
control(app, ui, d, "optics.defringeGreen", true);
let on = d.optics.defringe_green_amount > 0.0;
control(app, ui, d, "optics.defringeGreenHueLo", on);
control(app, ui, d, "optics.defringeGreenHueHi", on);
sub_title(ui, crate::i18n::tr("Lateral Chromatic Aberration"));
control(app, ui, d, "optics.caRed", true);
control(app, ui, d, "optics.caBlue", true);
}
ui.add_space(8.0);
});
section(app, ui, &d, "lensBlur", "Lens Blur", |app, ui, d| {
lens_blur(app, ui, d);
ui.add_space(8.0);
});
// Lightroom Classic's Calibration panel (the cloud app hides it): last, like there.
section(app, ui, &d, "calibration", "Calibration", |app, ui, d| {
sub_title(ui, crate::i18n::tr("Shadows"));
control(app, ui, d, "calibration.shadowsTint", true);
for (title, k) in [("Red Primary", "red"), ("Green Primary", "green"), ("Blue Primary", "blue")] {
sub_title(ui, title);
control(app, ui, d, &format!("calibration.{k}Hue"), true);
control(app, ui, d, &format!("calibration.{k}Sat"), true);
}
ui.add_space(8.0);
});
ui.add_space(40.0);
// A pending numeric edit commits on blur before the explicit Reset takes precedence.
if reset_clicked {
let _ = app.run("develop.reset", json!({}));
}
}
No file is open. Choose one in the tree, or press Ctrl+O (⌘O on a Mac) to find one by name.
Syntax highlighting could not load. The unmodified read-only text remains available above.