GitCorner

Code

ossartcraftfigcraft🌐
b45255bb6fe2
//! Rendering in parallel bands matches rendering in one piece: effects that look past a band's
//! rows (inner shadows, background blurs) must not draw the band's edges into the picture.
#![cfg(not(target_arch = "wasm32"))]

use std::sync::Arc;

use super::*;
use figcraft_color::{ImageScaleMode, Paint};
use figcraft_doc::{Effect, EffectKind, ImageData, Shadow};

fn inner_shadow(offset: (f64, f64), radius: f64, spread: f64) -> Effect {
    Effect {
        kind: EffectKind::InnerShadow(Shadow { color: Color::from_hex("000000B3").unwrap(), offset, radius, spread, ..Default::default() }),
        visible: true,
    }
}

fn png() -> Vec<u8> {
    let img = image::RgbaImage::from_fn(64, 64, |x, y| image::Rgba([(x * 4) as u8, (y * 4) as u8, 160, 255]));
    let mut out = Vec::new();
    img.write_to(&mut std::io::Cursor::new(&mut out), image::ImageFormat::Png).unwrap();
    out
}

/// An image-filled ellipse and a rotated solid rectangle, with inner shadows (`shadows`), and a
/// glass panel (background blur) over both (`glass`).
fn scene(shadows: bool, glass: bool) -> (Document, NodeId) {
    let mut d = Document::new("bands");
    let p = d.first_page().unwrap();
    // Image ids are content hashes in real documents and key the shared decode cache, so test
    // fixtures running in parallel need ids of their own.
    d.images.insert("band-tests-gradient".into(), ImageData { bytes: Arc::new(png()), width: 64, height: 64 });
    let e = d.create(p, NodeKind::Ellipse { start: 0.0, sweep: std::f64::consts::TAU, inner: 0.0 }, "E", 0.0, 0.0, 200.0, 200.0).unwrap();
    let n = d.get_mut(e).unwrap();
    n.fills = vec![Paint::image("band-tests-gradient", ImageScaleMode::Fill)];
    if shadows {
        n.effects = vec![inner_shadow((0.0, 4.0), 8.0, 0.0)];
    }
    let r = d.create(p, NodeKind::Rectangle, "R", 0.0, 0.0, 150.0, 180.0).unwrap();
    let n = d.get_mut(r).unwrap();
    n.fills = vec![Paint::solid(Color::from_hex("3C8CE6").unwrap())];
    n.transform = Affine::translate((260.0, 10.0)) * Affine::rotate(0.35);
    if shadows {
        n.effects = vec![inner_shadow((4.0, 4.0), 12.0, 2.0)];
    }
    if glass {
        let g = d.create(p, NodeKind::Rectangle, "Glass", 40.0, 60.0, 320.0, 120.0).unwrap();
        let n = d.get_mut(g).unwrap();
        n.fills = vec![Paint::solid(Color::from_hex("FFFFFF33").unwrap())];
        n.effects = vec![Effect { kind: EffectKind::BackgroundBlur(figcraft_doc::Blur::uniform(12.0)), visible: true }];
    }
    (d, p)
}

fn view(scale: f64) -> View {
    View { origin: (-10.0, -10.0), scale, width: (440.0 * scale) as u32, height: (240.0 * scale) as u32 }
}

/// A pixel whose largest channel differs by at most this much between two renders is edge
/// antialiasing noise (a curve clipped at a band's edge rasterises a hair differently, most where
/// it runs level, as at the top of an ellipse), not a band artifact.
const NOISE: u8 = 24;

/// One row of two renders: the channel differences of the pixels above noise (see `NOISE`) summed
/// and divided by the whole row's channel count, so noise pixels add nothing but still count in
/// the denominator; and how many pixels differ by more than 2 at all. A band artifact differs along
/// a whole row, by more than noise.
fn row_stats(x: &[u8], y: &[u8]) -> (f64, usize) {
    let mut sum = 0.0;
    let mut off = 0;
    for (p, q) in x.chunks(4).zip(y.chunks(4)) {
        let worst = p.iter().zip(q).map(|(c, d)| c.abs_diff(*d)).max().unwrap_or(0);
        if worst > 2 {
            off += 1;
        }
        if worst > NOISE {
            sum += p.iter().zip(q).map(|(c, d)| f64::from(c.abs_diff(*d))).sum::<f64>();
        }
    }
    (sum / x.len().max(1) as f64, off)
}

fn row_diffs(a: &Pixmap, b: &Pixmap) -> Vec<(f64, usize)> {
    let row = a.width() as usize * 4;
    a.data().chunks(row).zip(b.data().chunks(row)).map(|(x, y)| row_stats(x, y)).collect()
}

/// Whether a row passes: the original 0.25 limit on the mean from `row_stats`, and at most a
/// twentieth of the row differing at all.
fn row_ok(mean: f64, off: usize, width: usize) -> bool {
    mean < 0.25 && off * 20 <= width
}

#[test]
fn a_real_band_artifact_fails_but_edge_noise_passes() {
    let width = 880; // scale 2
    let flat = vec![100u8; width * 4];
    // 44 pixels whose colour channels differ by 60 (alpha unchanged): the mean is
    // 44 * 3 * 60 / (880 * 4) = 2.25, and the count, 44, is within a twentieth of the row. A real
    // artifact, so it fails on the mean.
    let mut artifact = flat.clone();
    for px in artifact.chunks_mut(4).take(44) {
        px.iter_mut().take(3).for_each(|c| *c += 60);
    }
    let (mean, off) = row_stats(&flat, &artifact);
    assert!(!row_ok(mean, off, width), "{mean} {off}");
    // 8 pixels differing by 16 (the ellipse top's antialiasing): forgiven.
    let mut noise = flat.clone();
    for px in noise.chunks_mut(4).take(8) {
        px.iter_mut().for_each(|c| *c += 16);
    }
    let (mean, off) = row_stats(&flat, &noise);
    assert!(row_ok(mean, off, width), "{mean} {off}");
}

#[test]
fn bands_match_one_piece_rendering() {
    let (d, p) = scene(true, true);
    for scale in [1.0, 2.0] {
        let v = view(scale);
        let one = render_view_single(&d, p, &v, &Options::default()).unwrap();
        for bands in [2, 3, 7] {
            let banded = render_bands(&d, p, &v, &Options::default(), bands).unwrap();
            assert_eq!((banded.width(), banded.height()), (one.width(), one.height()));
            for (y, (mean, off)) in row_diffs(&one, &banded).into_iter().enumerate() {
                assert!(row_ok(mean, off, v.width as usize), "scale {scale}, {bands} bands: row {y} differs ({off} pixels, {mean:.2} on average)");
            }
        }
    }
}

#[test]
fn inner_shadow_leaves_the_interior_alone() {
    // Far from the ellipse's edge, the image fill shows exactly as without the shadow, on every row
    // (the shadow used to draw a band at each render band's edge).
    let (with, p) = scene(true, false);
    let (without, _) = scene(false, false);
    let v = view(2.0);
    let a = render_bands(&with, p, &v, &Options::default(), 6).unwrap();
    let b = render_bands(&without, p, &v, &Options::default(), 6).unwrap();
    // Ellipse centre (100, 100) page units; the shadow reaches 3 sigma + offset = 16 units in.
    let (cx, cy, r) = (110.0 * 2.0, 110.0 * 2.0, (100.0 - 20.0) * 2.0);
    let mut checked = 0;
    for y in 0..v.height {
        for x in 0..v.width {
            let (dx, dy) = (f64::from(x) - cx, f64::from(y) - cy);
            if dx * dx + dy * dy > r * r {
                continue;
            }
            let i = ((y * v.width + x) * 4) as usize;
            assert_eq!(a.data()[i..i + 4], b.data()[i..i + 4], "pixel {x},{y}");
            checked += 1;
        }
    }
    assert!(checked > 10_000, "{checked}");
}

#[test]
fn huge_backdrop_blur_renders_in_one_piece() {
    let (mut d, p) = scene(true, true);
    let g = d.find_by_name("Glass", None)[0];
    d.get_mut(g).unwrap().effects = vec![Effect { kind: EffectKind::BackgroundBlur(figcraft_doc::Blur::uniform(1e6)), visible: true }];
    assert!(render_bands(&d, p, &view(1.0), &Options::default(), 4).is_none());
    assert!(render_view(&d, p, &view(1.0), &Options::default()).is_some());
}

/// [`row_diffs`] down the columns: an artifact of column bands runs down a whole column.
fn col_diffs(a: &Pixmap, b: &Pixmap) -> Vec<(f64, usize)> {
    let (w, h) = (a.width() as usize, a.height() as usize);
    let column = |p: &Pixmap, x: usize| -> Vec<u8> { (0..h).flat_map(|y| p.data()[(y * w + x) * 4..(y * w + x) * 4 + 4].to_vec()).collect() };
    (0..w).map(|x| row_stats(&column(a, x), &column(b, x))).collect()
}

#[test]
fn columns_match_one_piece_rendering() {
    let (d, p) = scene(true, true);
    for scale in [1.0, 2.0] {
        let v = view(scale);
        let one = render_view_single(&d, p, &v, &Options::default()).unwrap();
        for bands in [2, 3, 7] {
            let banded = render_columns(&d, p, &v, &Options::default(), bands).unwrap();
            assert_eq!((banded.width(), banded.height()), (one.width(), one.height()));
            for (x, (mean, off)) in col_diffs(&one, &banded).into_iter().enumerate() {
                assert!(
                    row_ok(mean, off, v.height as usize),
                    "scale {scale}, {bands} columns: column {x} differs ({off} pixels, {mean:.2} on average)"
                );
            }
        }
    }
    let (mut d, p) = scene(true, true);
    let g = d.find_by_name("Glass", None)[0];
    d.get_mut(g).unwrap().effects = vec![Effect { kind: EffectKind::BackgroundBlur(figcraft_doc::Blur::uniform(1e6)), visible: true }];
    assert!(render_columns(&d, p, &view(1.0), &Options::default(), 4).is_none(), "a blur past a whole column: in one piece");
}

/// The strips a pan uncovers render in bands along their longer side, and match one piece: no row
/// or column where a band's edge shows (a seam differs along all of it). A strip is too narrow for
/// [`row_ok`]'s mean: the edge antialiasing every band render has (a few pixels along a curve)
/// outweighs it there, so this counts the pixels that differ at all.
#[test]
fn a_tall_or_wide_part_of_a_view_matches_one_piece_rendering() {
    let (d, p) = scene(true, true);
    for (w, h) in [(60, 480), (880, 60), (200, 200)] {
        let v = View { origin: (35.0, -10.0), scale: 2.0, width: w, height: h };
        let one = render_view_single(&d, p, &v, &Options::default()).unwrap();
        let part = render_part(&d, p, &v, &Options::default()).unwrap();
        assert_eq!((part.width(), part.height()), (w, h));
        for (y, (_, off)) in row_diffs(&one, &part).into_iter().enumerate() {
            assert!(off * 20 <= w as usize, "{w} x {h}: row {y} differs in {off} pixels");
        }
        for (x, (_, off)) in col_diffs(&one, &part).into_iter().enumerate() {
            assert!(off * 20 <= h as usize, "{w} x {h}: column {x} differs in {off} pixels");
        }
    }
}
/// A textured layer scatters its pixels up to the texture's radius, past where a band cuts the
/// view; it is drawn off screen whole before it is cut, so column and row bands show it exactly as
/// one piece does, clipped to its shape or not.
#[test]
fn a_textured_layer_renders_the_same_in_bands() {
    for clip_to_shape in [false, true] {
        let mut d = Document::new("texture");
        let p = d.first_page().unwrap();
        let r = d.create(p, NodeKind::Rectangle, "T", 20.0, 20.0, 400.0, 200.0).unwrap();
        let n = d.get_mut(r).unwrap();
        n.fills = vec![Paint::solid(Color::from_hex("E03030").unwrap())];
        let texture = figcraft_doc::Texture { size: 0.5, radius: 12.0, clip_to_shape, ..Default::default() };
        n.effects = vec![Effect { kind: EffectKind::Texture(texture), visible: true }];
        let v = View { origin: (0.0, 0.0), scale: 1.7, width: 760, height: 400 };
        let one = render_view_single(&d, p, &v, &Options::default()).unwrap();
        for bands in [2, 3, 7] {
            assert!(render_columns(&d, p, &v, &Options::default(), bands).unwrap().data() == one.data(), "{bands} columns");
            assert!(render_bands(&d, p, &v, &Options::default(), bands).unwrap().data() == one.data(), "{bands} rows");
        }
    }
}