GitCorner

Code

ossartcraftfigcraft🌐
b45255bb6fe2
//! Increase and decrease font weight step through the styles the family has, by weight with the
//! same slant and width (#1831), not by 100 to a canonical name no face provides.

use figcraft_doc::{NodeId, TextStyle};
use serde_json::json;

use crate::Session;
use crate::cmd::text::{name_weight, next_style};

/// A family's styles listed by the weights their names say, as for faces not read yet.
fn styles(names: &[&str]) -> Vec<(String, u16)> {
    names.iter().map(|s| ((*s).to_string(), name_weight(s))).collect()
}

/// A family's styles with the faces' own weights.
fn weighed(faces: &[(&str, u16)]) -> Vec<(String, u16)> {
    faces.iter().map(|(s, w)| ((*s).to_string(), *w)).collect()
}

fn at(style: &str) -> TextStyle {
    let mut st = TextStyle::default();
    st.set_font_style(style);
    st
}

/// Walk `from` heavier (`up`) or lighter until the family has nothing further.
fn walk(family: &[(String, u16)], from: &str, up: bool) -> Vec<String> {
    let mut st = at(from);
    let mut out = Vec::new();
    while let Some(next) = next_style(family, &st, up) {
        st.set_font_style(next.clone());
        out.push(next);
    }
    out
}

#[test]
fn the_steps_follow_the_family_with_the_same_slant_and_width() {
    let arial = styles(&["Narrow", "Regular", "Italic", "Narrow Italic", "Bold", "Narrow Bold", "Bold Italic", "Narrow Bold Italic", "Black"]);
    assert_eq!(walk(&arial, "Regular", true), ["Bold", "Black"]);
    assert_eq!(walk(&arial, "Black", false), ["Bold", "Regular"]);
    assert_eq!(walk(&arial, "Italic", true), ["Bold Italic"]);
    assert_eq!(walk(&arial, "Narrow", true), ["Narrow Bold"]);
    assert_eq!(walk(&arial, "Narrow Bold Italic", false), ["Narrow Italic"]);
    let segoe = styles(&["Light", "Semilight", "Regular", "Italic", "Semibold", "Bold", "Black", "Bold Italic"]);
    assert_eq!(walk(&segoe, "Regular", true), ["Semibold", "Bold", "Black"]);
    assert_eq!(walk(&segoe, "Regular", false), ["Semilight", "Light"]);
    // A style the family doesn't have (as the old steps stored) moves to the next real one.
    assert_eq!(next_style(&segoe, &at("Medium"), true).as_deref(), Some("Semibold"));
}

#[test]
fn extra_and_semi_before_a_width_keep_the_width() {
    let family = styles(&["Extra Condensed Regular", "Condensed Regular", "Condensed Bold", "Extra Condensed Bold", "Semi Condensed Extra Bold"]);
    assert_eq!(walk(&family, "Extra Condensed Regular", true), ["Extra Condensed Bold"]);
    assert_eq!(walk(&family, "Condensed Bold", false), ["Condensed Regular"]);
    assert_eq!(walk(&family, "Semi Condensed Extra Bold", false), Vec::<String>::new());
}

#[test]
fn oblique_names_step_to_oblique_faces() {
    let dejavu = styles(&["Book", "Oblique", "Bold", "Bold Oblique"]);
    assert_eq!(walk(&dejavu, "Oblique", true), ["Bold Oblique"]);
    assert_eq!(walk(&dejavu, "Bold Oblique", false), ["Oblique"]);
    assert_eq!(walk(&dejavu, "Book", true), ["Bold"]);
}

#[test]
fn hairline_and_w_numbers_are_weights() {
    let family = styles(&["Hairline", "Thin", "Regular", "Bold"]);
    assert_eq!(walk(&family, "Regular", false), ["Thin", "Hairline"]);
    // Off the list (a stored style the family lacks): by weight, the nearer of two equal ones.
    assert_eq!(next_style(&family, &at("Extra Light"), false).as_deref(), Some("Thin"));
    assert_eq!(next_style(&family, &at("Extra Light"), true).as_deref(), Some("Regular"));
    let hiragino = styles(&["W3", "W6"]);
    assert_eq!(walk(&hiragino, "W3", true), ["W6"]);
    assert_eq!(next_style(&hiragino, &at("Bold"), false).as_deref(), Some("W6"));
}

#[test]
fn number_weights_count_after_a_width_but_other_numbers_dont() {
    // An off-list "Condensed 600" is 600, as "600" alone is: between Condensed 500 and 700.
    let condensed = weighed(&[("Condensed 300", 300), ("Condensed 500", 500), ("Condensed 700", 700)]);
    assert_eq!(next_style(&condensed, &at("Condensed 600"), true).as_deref(), Some("Condensed 700"));
    assert_eq!(next_style(&condensed, &at("Condensed 600"), false).as_deref(), Some("Condensed 500"));
    assert_eq!((name_weight("Condensed 600"), name_weight("600 Italic"), name_weight("Condensed 1000")), (600, 600, 1000));
    // A number that isn't a weight (a width grade, an optical size) is part of the width.
    assert_eq!((name_weight("Condensed 2"), name_weight("Caption 12 Bold"), name_weight("Condensed +600")), (400, 700, 400));
    let optical = styles(&["Caption 12 Regular", "Caption 24 Regular", "Caption 12 Bold", "Caption 24 Bold"]);
    assert_eq!(walk(&optical, "Caption 12 Regular", true), ["Caption 12 Bold"]);
    assert_eq!(walk(&optical, "Caption 24 Bold", false), ["Caption 24 Regular"]);
}

#[test]
fn univers_numbers_step_by_weight_within_their_width() {
    // Helvetica Neue LT, Univers, Frutiger: the first digit grades the weight, the second the width.
    let hn = weighed(&[
        ("45 Light", 300),
        ("46 Light Italic", 300),
        ("55 Roman", 400),
        ("56 Italic", 400),
        ("57 Condensed", 400),
        ("65 Medium", 500),
        ("67 Medium Condensed", 500),
        ("75 Bold", 700),
        ("76 Bold Italic", 700),
        ("77 Bold Condensed", 700),
    ]);
    assert_eq!(walk(&hn, "55 Roman", true), ["65 Medium", "75 Bold"]);
    assert_eq!(walk(&hn, "65 Medium", false), ["55 Roman", "45 Light"]);
    assert_eq!(walk(&hn, "57 Condensed", true), ["67 Medium Condensed", "77 Bold Condensed"]);
    assert_eq!(walk(&hn, "67 Medium Condensed", false), ["57 Condensed"]);
    assert_eq!(walk(&hn, "46 Light Italic", true), ["56 Italic", "76 Bold Italic"]);
    // Faces not read yet: the words after the number give the weight.
    let univers = styles(&["45 Light", "55 Roman", "65 Bold", "75 Black", "57 Condensed", "67 Bold Condensed"]);
    assert_eq!(walk(&univers, "45 Light", true), ["55 Roman", "65 Bold", "75 Black"]);
    assert_eq!(walk(&univers, "67 Bold Condensed", false), ["57 Condensed"]);
    assert_eq!((name_weight("45 Light"), name_weight("75 Black"), name_weight("57 Condensed")), (300, 900, 400));
    // Other leading numbers stay part of the width: before another word, or not a width digit.
    let other = styles(&["12 Regular", "12 Bold", "55 Rounded", "55 Rounded Bold", "Regular", "Bold"]);
    assert_eq!(walk(&other, "12 Regular", true), ["12 Bold"]);
    assert_eq!(walk(&other, "55 Rounded", true), ["55 Rounded Bold"]);
    assert_eq!(walk(&other, "Regular", true), ["Bold"]);
}

#[test]
fn a_custom_weight_axis_value_steps_from_where_it_is() {
    let family = styles(&["Light", "Regular", "Medium", "Bold"]);
    let mut st = at("Regular");
    st.variations.insert("wght".into(), 550.0);
    assert_eq!(next_style(&family, &st, true).as_deref(), Some("Bold"));
    assert_eq!(next_style(&family, &st, false).as_deref(), Some("Medium"));
}

#[test]
fn off_the_list_the_faces_own_weights_decide() {
    // From 500 between 400 and 700 faces: the neighbours, under their own names (the axis value goes).
    let family = weighed(&[("Light", 300), ("Regular", 400), ("Bold", 700)]);
    let mut st = at("Regular");
    st.variations.insert("wght".into(), 500.0);
    assert_eq!(next_style(&family, &st, true).as_deref(), Some("Bold"));
    assert_eq!(next_style(&family, &st, false).as_deref(), Some("Regular"));
    st.set_font_style("Bold");
    assert_eq!((st.weight(), st.variations.get("wght")), (700, None));
    // Segoe UI Variable's Semilight is 350, not the 300 its name says: from a `wght` of 325 it is
    // the next heavier style, and from 375 the next lighter.
    let segoe = weighed(&[("Light", 300), ("Semilight", 350), ("Regular", 400), ("Semibold", 600), ("Bold", 700)]);
    st.variations.insert("wght".into(), 325.0);
    assert_eq!(next_style(&segoe, &st, true).as_deref(), Some("Semilight"));
    assert_eq!(next_style(&segoe, &st, false).as_deref(), Some("Light"));
    st.variations.insert("wght".into(), 375.0);
    assert_eq!(next_style(&segoe, &st, false).as_deref(), Some("Semilight"));
    assert_eq!(next_style(&segoe, &st, true).as_deref(), Some("Regular"));
    // A W-numbered name with a slant after it is still that weight ("W7 Italic" is 700).
    let hiragino = weighed(&[("W3 Italic", 300), ("W6 Italic", 600), ("W8 Italic", 800)]);
    assert_eq!(next_style(&hiragino, &at("W7 Italic"), false).as_deref(), Some("W6 Italic"));
    assert_eq!(next_style(&hiragino, &at("W7 Italic"), true).as_deref(), Some("W8 Italic"));
    // And after a width ("Condensed W7 Italic" is 700 too).
    let condensed = weighed(&[("Condensed W3 Italic", 300), ("Condensed W6 Italic", 600), ("Condensed W8 Italic", 800)]);
    assert_eq!(next_style(&condensed, &at("Condensed W7 Italic"), true).as_deref(), Some("Condensed W8 Italic"));
    assert_eq!(next_style(&condensed, &at("Condensed W7 Italic"), false).as_deref(), Some("Condensed W6 Italic"));
}

fn font_style(s: &Session, t: NodeId) -> String {
    s.doc().unwrap().node(t).unwrap().kind.text().unwrap().spans()[0].2.font_style.clone()
}

#[test]
fn the_commands_land_on_styles_the_family_has() {
    figcraft_text::scan_system_fonts();
    // Any installed family with a Regular face and a style the step takes it to (CI machines differ).
    let pick = figcraft_text::family_names().into_iter().find_map(|f| {
        let st = figcraft_text::family_style_weights(&f);
        let up = next_style(&st, &at("Regular"), true).filter(|_| st.iter().any(|(x, _)| x == "Regular"))?;
        Some((f, st, up))
    });
    let Some((family, styles, heavier)) = pick else { return };
    let mut s = Session::new();
    let r = s.execute("node.create", &json!({"type": "text", "text": "Hi", "props": {"fontFamily": family, "fontStyle": "Regular"}})).unwrap();
    let t = crate::params::id_of(&r["id"]).unwrap();
    s.execute("text.weightUp", &json!({"ids": [t]})).unwrap();
    let up = font_style(&s, t);
    assert_eq!(up, heavier, "{family}: {styles:?}");
    s.execute("text.weightDown", &json!({"ids": [t]})).unwrap();
    assert_eq!(font_style(&s, t), "Regular", "{family}: {styles:?}");
    // A family that isn't installed still steps by 100 under the canonical names.
    s.execute("node.set", &json!({"ids": [t], "props": {"fontFamily": "No Such Family 7f3a", "fontStyle": "Regular"}})).unwrap();
    s.execute("text.weightUp", &json!({"ids": [t]})).unwrap();
    assert_eq!(font_style(&s, t), "Medium");
}